Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Integer custom field to be numerical input instead of a drop-down #43697

Open
wants to merge 5 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

sakiss
Copy link
Contributor

@sakiss sakiss commented Jun 24, 2024

Pull Request for Issue #42579

Summary of Changes

So far the Integer custom field is a drop-down list.
Though it is crashing the browser when the list becomes too long. Moreover it is really hard to use, after a certain length.

With the PR the Integer custom field is an input of type number. Though, it still follows the min, max and step settings, that existed.

Testing Instructions

Try setting up a custom field of type "Integer" for an article.
Within the article you will see an input, instead of a drop-down,

Actual result BEFORE applying this Pull Request

Drop-down list.

Expected result AFTER applying this Pull Request

Input of type number

Link to documentations

DKN

@sakiss sakiss changed the title Integer custom field to be numerical Integer custom field to be numerical input instead of a drop-down Jun 24, 2024
@sakiss sakiss changed the base branch from 4.4-dev to 5.2-dev June 24, 2024 13:41
@Fedik
Copy link
Member

Fedik commented Jun 24, 2024

Thanks for the PR.
Before you continue. We should not change existing integer field. And instead of it, need to create a new Number custom field, which will use NumberField class.

@Quy Quy added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Jul 4, 2024
@sakiss sakiss changed the title Integer custom field to be numerical input instead of a drop-down [5.2] Integer custom field to be numerical input instead of a drop-down Jul 9, 2024
@crommie
Copy link

crommie commented Aug 24, 2024

I have tested this item ✅ successfully on a8e9be4

This does what it says. But Fedik's suggestion below sounds logical to me.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43697.

@pe7er
Copy link
Contributor

pe7er commented Aug 24, 2024

I have tested this item ✅ successfully on a8e9be4

Works like described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43697.

@brianteeman
Copy link
Contributor

This breaks backwards compatibility and should be a new field

@richard67
Copy link
Member

Not setting RTC due to reason stated in previous comment. The "Updates requested" label is already set.

@HLeithner HLeithner changed the base branch from 5.2-dev to 5.3-dev September 2, 2024 08:50
@HLeithner
Copy link
Member

This pull request has been automatically rebased to 5.3-dev.

@HLeithner HLeithner changed the title [5.2] Integer custom field to be numerical input instead of a drop-down [5.3] Integer custom field to be numerical input instead of a drop-down Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature PR-5.3-dev Updates Requested Indicates that this pull request needs an update from the author and should not be tested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants