[4.4] Use joomla-cypress 1.1.1 #43722

muhme · 2024-06-30T06:14:08Z

Summary of Changes

Revised after 27 commits on 7 August 2024

The goal is to use the NPM joomla-cypress version 1.1.1 for all four active joomla-cms branches. Actual 4.4-dev uses 0.0.16; and 5.1-dev, 5.2-dev and 6.0-dev are using 1.0.3.

The following changes have already been separated from this PR and have already been merged into 4.4-dev:

Also released is NPM package joomla-cypress as version 1.1.1. 😄

Change:

The joomla-cypress version is set to ^1.1.1, so - among other things - the check for PHP warnings is activated again.
The Cypress commands overwritten by System Tests for a faster session-based login have been removed as they are included in joomla-cypress version 1.1.1.
The note about overwritten commands in tests/System/README.md is deleted.

⚠️ Only NPM package joomla-cypress was updated, BUT there are more changes in package-lock.json. ⚠️

Reasons are
- Dependend packages like cypress and cypress-file-upload
- package.json and package-lock.json were not in-sync. For example in package.json the version is stated as '4.4.7' and in package-lock.json as '4.4.6'.

Successfully retested with all System Tests passed on 7 Agust 2024 after 27 commits:

on Intel macOS 14.5 Sonoma with PHP 8.3.9
on Intel Windows 11 Pro with Laragon and PHP 8.1.10
on Intel x86_64 Ubuntu 24.04 LTS Noble Numbat with PHP 8.3.6

Testing Instructions

Install (in using npm ci) and run System Tests w/o errors
Check version is 1.1.1 in node_modules/joomla-cypress/package.json
Check that the additional updates in the package-lock.json file had no effect.

Actual result BEFORE applying this Pull Request

System Tests is using joomla-cypress version 0.0.16 and a custom implementation of the faster session-based login
No checks of PHP warnings
System Tests suite is running without errors

Expected result AFTER applying this Pull Request

System Tests is using joomla-cypress actual version 1.1.1 and its session-based login
PHP warning checks are activated again
System Tests suite is running without errors

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed

Up-Merging

@LadySolveig @bembelimen I will create a separate different PR for 5.1-dev

Merge branch '4.4-dev'

Consider file permissions when writing configuration in system tests …

merge joomla/joomla-cms branch 4.4-dev

merge base 4.4-dev

The joomla-cypress NPM package used has been updated to the latest version in order to be able to use one version in all active joomla-cms branches. Other packages were also updated to the latest versions with the `npm update`. The overwritten Cypress commands for faster login with session have been deleted, as they are already included in the new joomla-cypress version.

hans2103 · 2024-06-30T17:46:29Z

I have tested this item ✅ successfully on 9a66d94

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43722.}

richard67 · 2024-06-30T22:01:21Z

@muhme Which command have you used to update the dependency? To me it seems this PR updates more dependencies than only joomla-cypress and it’s dependencies.

muhme · 2024-07-01T04:15:00Z

@muhme Which command have you used to update the dependency? To me it seems this PR updates more dependencies than only joomla-cypress and it’s dependencies.

@richard67 npm update to stay up-to-date with all dependencies. Should it changed to only update joomla-cypress and it’s dependencies?

richard67 · 2024-07-01T06:25:13Z

Should it changed to only update joomla-cypress and it’s dependencies?

@muhme Yes. We don’t do dependency updates with patch versions. And to update all dependencies without even mentioning it in the description of this PR would not be good anyway. @laoneo can explain and decide.

alikon · 2024-07-01T06:42:31Z

the #43726 should avoid the need for the hack in newsfeed and in the related_items module....

muhme · 2024-07-02T03:48:49Z

Set to DRAFT to:

Only update joomla-cypress and it’s dependencies
Remove joomla-cypress commands are overwritten in tests/System/README.md
Wait for fix for joomla-cypress 1.1.0 muhme/joomla-cms#6
Test again

muhme · 2024-07-02T13:37:56Z

And to update all dependencies without even mentioning it in the description of this PR would not be good anyway.

@richard67 Since the creation of this PR, the following statement has been included in the description:

⚠️ All other NPM packages are also updated with the npm update, see differences in package-lock.json.

The fact that all packages are updated is therefore explicitly named from my point of view and even provided with a visual eye-catcher. Also, the following instruction was added to the "Test Instructions" section since this PR was created:

Check that there were no effects from the updates in the NPM packages.

Could it be that you haven't read the description, or am I the one who's in the wrong movie? 😃

richard67 · 2024-07-02T14:08:18Z

@muhme Seems I need glasses 👓:-) You are right, description is ok, sorry for the noise :-)

merge from head repository

fix for joomla-cypress 1.1.0

muhme · 2024-07-09T15:31:39Z

Reverted to "Ready to merge", the description has been completely revised after all changes.

laoneo · 2024-07-22T13:51:10Z

Are the changes in the View classes really needed?

muhme · 2024-07-22T14:49:39Z

Are the changes in the View classes really needed?

In 4.4-dev with joomla-cypress 0.0.16 the PHP message and warningas checks were disabled. With joomla-cypress 1.1.0 they are enabled and the System tests had 6 failures. At first there were workaround 'hacks' in the system tests to get the test suite running without errors. @alikon solved all system test 'hacks' by backporting and investigating. @alikon: Can you explain more in detail?

laoneo · 2024-07-22T16:16:17Z

If these are bugs in the code, we should do them separate and then they need also two human tests.

brianteeman · 2024-07-22T16:27:20Z

Golden rule - solve one issue with one pull request

laoneo · 2024-08-06T08:56:11Z

As the other pr's are merged, can this one be changed to ready?

muhme · 2024-08-06T09:13:02Z

As the other pr's are merged, can this one be changed to ready?

No, it's intentionally set to 'Draft'. I would prefer to wait for the release of joomla-cypress 1.1.1 and then update this PR, set it on 'Ready to Merge' and create separate PR for all other branches, ok?

merge head repository joomla/joomla-cms

muhme · 2024-08-07T13:33:27Z

@laoneo Set to ready-for-review, as all preconditions have been fulfilled and the PR has been adjusted and pre-tested

@alikon Could you please test?

laoneo · 2024-08-07T16:41:28Z

Thanks!

* [cypress] Updated to joomla-cypress 1.1.0 The joomla-cypress NPM package used has been updated to the latest version in order to be able to use one version in all active joomla-cms branches. Other packages were also updated to the latest versions with the `npm update`. The overwritten Cypress commands for faster login with session have been deleted, as they are already included in the new joomla-cypress version. * Hack to prevent deprecated in mod_related_items * 3 more files with workarounds * no hack for modules * avoid hacks * avoid hacks * featured * featured * module * nomore * nomore * Fix missing apostrophe * NPM Update only joomla-cypress npm install joomla-cypress@1.1.0 * Update tests/System/README.md Removed notice on overridden joomla-cypress commands * Fixing lint:testjs errors * Undo the changes extracted to a separate PRs * npm update joomla-cypress 1.1.1 --------- Co-authored-by: Nicola Galgano <optimus4joomla@gmail.com> Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>

muhme added 7 commits June 7, 2024 06:47

Merge pull request #1 from joomla/4.4-dev

01012df

Merge branch '4.4-dev'

Merge pull request #2 from joomla/4.4-dev

4e535a5

Consider file permissions when writing configuration in system tests …

Merge pull request #3 from joomla/4.4-dev

cbec9f9

merge joomla/joomla-cms branch 4.4-dev

Merge pull request #4 from joomla/4.4-dev

faf278a

merge base 4.4-dev

Hack to prevent deprecated in mod_related_items

3f37dd7

3 more files with workarounds

9a66d94

joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.4-dev Unit/System Tests labels Jun 30, 2024

muhme marked this pull request as draft July 1, 2024 06:44

alikon mentioned this pull request Jul 1, 2024

[4] fix for cypress 1.1.0 hack #43726

Closed

alikon added 3 commits July 2, 2024 09:01

no hack for modules

81b27f3

avoid hacks

984a90b

avoid hacks

846ade1

muhme and others added 7 commits July 4, 2024 19:11

Merge pull request #5 from joomla/4.4-dev

7dc42f1

merge from head repository

featured

ae2ddbc

featured

b55b883

module

cdeb056

nomore

2aaf9be

nomore

901b8c6

Merge pull request #6 from alikon/patch-22

d89e5b7

fix for joomla-cypress 1.1.0

Fixing lint:testjs errors

59ee69a

muhme marked this pull request as ready for review July 9, 2024 15:29

muhme and others added 2 commits July 10, 2024 09:50

Merge branch '4.4-dev' into joomla-cypress-update

e1cbca5

Merge branch '4.4-dev' into joomla-cypress-update

1b1c840

muhme marked this pull request as draft July 22, 2024 17:00

This was referenced Aug 4, 2024

[4.4] Fix newsfeed category html view #43879

Merged

[4.4] Fix newsfeed html view #43880

Merged

[4.4] Set publish_up in db_createArticle #43881

Merged

muhme changed the title ~~Update to joomla-cypress 1.1.0~~ Update to joomla-cypress 1.1.1 Aug 4, 2024

muhme changed the title ~~Update to joomla-cypress 1.1.1~~ [4.4] Use joomla-cypress 1.1.1 Aug 4, 2024

muhme and others added 2 commits August 4, 2024 20:02

Undo the changes extracted to a separate PRs

d49142e

Merge branch '4.4-dev' into joomla-cypress-update

013e2e4

muhme added 2 commits August 7, 2024 14:14

npm update joomla-cypress 1.1.1

cd4092c

Merge pull request #12 from joomla/4.4-dev

34a0e35

merge head repository joomla/joomla-cms

muhme marked this pull request as ready for review August 7, 2024 13:29

muhme mentioned this pull request Aug 7, 2024

[5.x] Update joomla-cypress 1.1.1 #43892

Closed

4 tasks

laoneo merged commit 46c3bc0 into joomla:4.4-dev Aug 7, 2024
3 checks passed

laoneo added this to the Joomla! 4.4.7 milestone Aug 7, 2024

muhme deleted the joomla-cypress-update branch August 7, 2024 16:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[4.4] Use joomla-cypress 1.1.1 #43722

[4.4] Use joomla-cypress 1.1.1 #43722

muhme commented Jun 30, 2024 •

edited

Loading

hans2103 commented Jun 30, 2024

richard67 commented Jun 30, 2024

muhme commented Jul 1, 2024

richard67 commented Jul 1, 2024 •

edited

Loading

alikon commented Jul 1, 2024 •

edited

Loading

muhme commented Jul 2, 2024 •

edited

Loading

muhme commented Jul 2, 2024

richard67 commented Jul 2, 2024

muhme commented Jul 9, 2024

laoneo commented Jul 22, 2024

muhme commented Jul 22, 2024

laoneo commented Jul 22, 2024

brianteeman commented Jul 22, 2024

laoneo commented Aug 6, 2024

muhme commented Aug 6, 2024

muhme commented Aug 7, 2024

laoneo commented Aug 7, 2024

[4.4] Use joomla-cypress 1.1.1 #43722

[4.4] Use joomla-cypress 1.1.1 #43722

Conversation

muhme commented Jun 30, 2024 • edited Loading

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Up-Merging

hans2103 commented Jun 30, 2024

richard67 commented Jun 30, 2024

muhme commented Jul 1, 2024

richard67 commented Jul 1, 2024 • edited Loading

alikon commented Jul 1, 2024 • edited Loading

muhme commented Jul 2, 2024 • edited Loading

muhme commented Jul 2, 2024

richard67 commented Jul 2, 2024

muhme commented Jul 9, 2024

laoneo commented Jul 22, 2024

muhme commented Jul 22, 2024

laoneo commented Jul 22, 2024

brianteeman commented Jul 22, 2024

laoneo commented Aug 6, 2024

muhme commented Aug 6, 2024

muhme commented Aug 7, 2024

laoneo commented Aug 7, 2024

muhme commented Jun 30, 2024 •

edited

Loading

richard67 commented Jul 1, 2024 •

edited

Loading

alikon commented Jul 1, 2024 •

edited

Loading

muhme commented Jul 2, 2024 •

edited

Loading