[cypress] ESM docu update II #43731
Merged
[cypress] ESM docu update II #43731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the joomla#43702 ESM documentation update, the small problem has arisen that `npx` uses `cypress.config.js` in error messages, although `cypress.config.mjs` is used. This was 'fixed' in using `npm`. Unfortunately, it turned out that: * npx cypress run --spec is not replaceable by: * npm run cypress:run --spec therefore changed back. A short note has been added to the Troubleshooting section. It was also discovered that the environment variable in the `sudo` call was set in the wrong order, which has been corrected.
merge from head-repository joomla/joomla-cms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
With #43676 the Cypress tests are moved to ESM and the small problem has arisen that
npxusescypress.config.jsin error messages, althoughcypress.config.mjsis used. This was 'fixed' in usingnpmwith #43702 . Unfortunately, it turned out that:is not replaceable by:
Therefore, the places that use the
--specoption have been changed back tonpxand a short note has been added to the Troubleshooting section.It was also discovered that the environment variable in the
sudocall was set in the wrong order, which has been corrected too.Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed