Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Cypress typos/grammar #43853

Merged
merged 7 commits into from
Sep 12, 2024
Merged

[4.4] Cypress typos/grammar #43853

merged 7 commits into from
Sep 12, 2024

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Jul 26, 2024

Cypress typos/grammar

remake of #43833

@brianteeman brianteeman changed the title Update Actionlogs.cy.js [4.4] Cypress typos/grammar Jul 26, 2024
@brianteeman brianteeman marked this pull request as ready for review July 26, 2024 18:49
@brianteeman brianteeman mentioned this pull request Jul 26, 2024
4 tasks
@Quy
Copy link
Contributor

Quy commented Jul 27, 2024

I have tested this item ✅ successfully on 8c92897


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43853.

@chmst
Copy link
Contributor

chmst commented Aug 24, 2024

I have tested this item ✅ successfully on 4cd1d3f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43853.

1 similar comment
@softforge
Copy link
Contributor

I have tested this item ✅ successfully on 4cd1d3f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43853.

@Quy
Copy link
Contributor

Quy commented Aug 24, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43853.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 24, 2024
@laoneo
Copy link
Member

laoneo commented Aug 30, 2024

To the testers here, is this a correct sentence:

Test in backend that the action logs has a title.

Should it not be:

Test in backend that the action logs have a title.

@brianteeman
Copy link
Contributor Author

No it should not - We are testing that the page has a title. The page is a singular item therefore it is has not have

@laoneo laoneo merged commit 88fbc2c into joomla:4.4-dev Sep 12, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 12, 2024
@laoneo
Copy link
Member

laoneo commented Sep 12, 2024

Ok, fine for me then. Probably we should change all occurences then to "Test in backend that the xxx page has yyy." to make it more clear. But this is for another time.

@laoneo laoneo added this to the Joomla! 4.4.9 milestone Sep 12, 2024
@brianteeman brianteeman deleted the patch-3 branch September 12, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants