[4.x] Fix paginated page links for com_finder and com_content archive

[SniperSister]

Summary of Changes

The 4.4.7 and 5.1.3 security release broke the pagination in com_finder (thanks Phil for reporting) and the com_content archive view.

Testing Instructions

Create a test site with a sufficient amount of articles to get a paginated result for the com_finder search results. Click on the pagination links.

Furthermore create an archive view with a sufficient amount of articles that filters for a specific category.

Actual result BEFORE applying this Pull Request

• finder: Search parameters and search word are lost.
• archive: catid parameter is lost

Expected result AFTER applying this Pull Request

• finder: Search parameters and search word are appended to the URL.
• archive: catid parameter is appended

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[richard67]

I have tested this item ✅ successfully on c6b8a24

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43953.}

[richard67]

Hint for other testers: The issue can be easily reproduced and the fix be tested when installing Blog sample data on a clean, current 4.4.7, adding a finder menu item and in the advanced settings for that menu item set the items per page to 5. Then call the page in frontend and search for "Joomla". Then check the links of the 2nd, 3rd, next and last page in the pagination.

[coolcat-creations]

I have tested this item ✅ successfully on c6b8a24

Patch Works also in Joomla 5.1.3

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43953.}

[richard67]

I've restored the previous human test results in the issue tracker as the change which invalidated the test count was just a code style change.

=> RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43953.}

[dautrich]

I have tested this item ✅ successfully on c9aaf5b

Tested on 5.1.3

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43953.}

[peteruoi]

Is there gonna be an immediate new release and wait for it or its gonna be days?

[bembelimen]

No release today

[dautrich]

@peteruoi
You shouldn't wait with your update to J5.1.3, because the update is a security update. If necessary, you can apply the patch from this PR manually. It is an easy task, because only one file is involved; you only need to add some lines of code in one place.

[SniperSister]

@dautrich @richard67 @coolcat-creations I updated the PR to also cover a second bug in the com_content archive view, a test for that scenario would be much appreciated!

[coolcat-creations]

@SniperSister Test not successful ... See here with applied patch: https://playground.designedwithlove.de/de/archiv?month=0&year=2024&catid[0]=&start=5 and search for "About" - the title filter is reset on pagination change

[SniperSister]

@coolcat-creations excellent catch! Fixed!

[coolcat-creations]

@SniperSister what did you fix before because I could not catch an error before the fix there? :-)

[SniperSister]

@coolcat-creations i fixed the title filter that you mentioned

[coolcat-creations]

Ok thanks

[coolcat-creations]

Test successful

[jjnxpct]

@peteruoi You shouldn't wait with your update to J5.1.3, because the update is a security update. If necessary, you can apply the patch from this PR manually. It is an easy task, because only one file is involved; you only need to add some lines of code in one place.

If you have many sites to manage (100+) manually fixing stuff will take a lot more time. So an update / fix through the Joomla updater would be very much appreciated.

[richard67]

Back to pending as there were made changes.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43953.}

[richard67]

@peteruoi You shouldn't wait with your update to J5.1.3, because the update is a security update. If necessary, you can apply the patch from this PR manually. It is an easy task, because only one file is involved; you only need to add some lines of code in one place.

If you have many sites to manage (100+) manually fixing stuff will take a lot more time. So an update / fix through the Joomla updater would be very much appreciated.

@jjnxpct If your sites are all on 5.1.3, you have to do that only one time, and for the others you can just copy the 2 modified files. For sites which are on 4.4.7 you can directly use the modified files from this PR

[coolcat-creations]

I have tested this item ✅ successfully on 8245571

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43953.}

[JohnVesey]

Notes from a user:

1. Fix works on J5.1.3 on PHP 8.2.15
2. I needed to re-index Smart Search in /administrator as blank results were given when searching on the frontend.

Thank you for this fix 👍

[hans2103]

I have tested this item ✅ successfully on 8245571

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43953.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43953.}

[SniperSister]

I've merged the aditional Parameters that @Fedik suggested in #43954 to get one combined PR fixing the regressions

[richard67]

Back to pending as there were made changes.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43953.}

[richard67]

@coolcat-creations @dautrich @hans2103 Could you test again? Thanks in advance.

[hans2103]

I have tested this item ✅ successfully on 20d41c3

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43953.}

[dautrich]

I have tested this item ✅ successfully on 20d41c3

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43953.}

[dautrich]

Hopefully, this is the last time this PR goes RTC.

[alikon]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43953.}

[MacJoom]

Thank you for the quick fix!

[fontanil]

I have tested this item ✅ successfully on 20d41c3

Tested successfully on a 5.1.4-RC-1 version

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43953.}

[sakiss]

@SniperSister What about the "o" and "od" variables?
They stand for ordering and ordering direction.
Enable the "Show Sort Fields" setting in the Smart Search menu item (under Advanced).
Then use the ordering fields to change the order, in a result set that has several pages and try to change page.
The ordering field and direction are vanished.

[SniperSister]

@sakiss good catch, see #43967