Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] Update NPM developer dependencies braces, fill-range, micromatch and rollup #44159

Merged

Conversation

richard67
Copy link
Member

@richard67 richard67 commented Sep 29, 2024

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the following NPM dependencies which are used for development:

  • node_modules/braces from 3.0.2. to 3.0.3
  • node_modules/fill-range (indirect dependency from braces) from 7.0.1 to 7.1.1
  • node_modules/micromatch (indirect dependency from braces) from 4.0.5 to 4.0.8
  • node_modules/rollup from 2.79.1 to 2.79.2

This fixes 3 issues reported by npm audit.

Hint for 5.2 release managers: These changes don't need to be merged up into 5.2-dev as the mentioned dependencies have been updated there already with other PRs. So on the next upmerge if there is a conflict with this, just use what's on 5.2-dev.

Testing Instructions

Check e.g. in Drone if npm and the upload package build still succeed, and check the detailed log in Drone for one of these 2 regarding issues reported by npm audit.

Actual result BEFORE applying this Pull Request

Works, but npm audit reports 3 issues which can be fixed with npm audit fix (and one for TinyMCE < 7 which is a known false alarm).

Expected result AFTER applying this Pull Request

Works, and npm audit doesn't report these 3 issues anymore.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

Update node_modules/braces to 3.0.3.
Update node_modules/fill-range to 7.1.1.
Update node_modules/micromatch to 4.0.8.
Update node_modules/rollup to 2.79.2.
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.4-dev labels Sep 29, 2024
@MacJoom MacJoom self-assigned this Sep 30, 2024
@MacJoom MacJoom added this to the Joomla! 4.4.9 milestone Sep 30, 2024
@MacJoom MacJoom merged commit 4f03ecc into joomla:4.4-dev Sep 30, 2024
3 checks passed
@MacJoom
Copy link
Contributor

MacJoom commented Sep 30, 2024

Thank you!

@richard67 richard67 deleted the 4.4-dev-update-node-modules-2024-09-29 branch September 30, 2024 19:48
richard67 added a commit that referenced this pull request Oct 8, 2024
[5.3] Upmerge 2024-10-08:
- [4.4] Update NPM developer dependencies braces, fill-range, micromatch and rollup #44159 
- [4.4] Fix the actions menu in the admin isn't working on mobile #44199 
- [5.2][GuidedTours] replace deprecated access of input property #44195 
- [5.2] Translation Update #44191 
- [5.2] SEF: Don't remove trailingslash on hp in a subdir #44205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.4-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants