[5.3] Removing dealerdirect/phpcodesniffer-composer-installer entirely #44757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one here has now a conflict because of #44657. |
Hackwar
force-pushed
the
5.3-dependency-codesniffer
branch
from
27046a9 to
94e3e22
Compare
|
I recreated the PR. Should be ready now. |
Hackwar
changed the title
|
I updated the PR to remove this entirely, since we don't need this dependency at all anymore. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Since we are using a built-in codestyle, we don't need the dealerdirect/phpcodesniffer-composer-installer package anymore, thus removing this. Since it is part of the dev dependencies, we can remove it whenever we want.
Testing Instructions
Codereview