Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3rd try for inline SVG icons.
This is ONLY for demo purposes, if it gets a consensus there would be be a proper PR
Prior work:
Summary of Changes
[ name => svgCode ]
) with all the FA iconsScope
Testing Instructions
I Just covered few icons so that it's easy for any reviewers to check what is happening.
The icon part could be done with a Layout for even easier usage.
I picked the show/hide password to showcase the JS changes (supports both font/inline svg icons)
Actual result BEFORE applying this Pull Request
Login
Cpanel
Expected result AFTER applying this Pull Request
Login
Cpanel
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
@laoneo @HLeithner @bembelimen @SniperSister @rdeutz