Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Fix $dirname description #44782

Draft
wants to merge 3 commits into
base: 5.3-dev
Choose a base branch
from
Draft

Conversation

QuyTon
Copy link
Contributor

@QuyTon QuyTon commented Jan 26, 2025

Testing Instructions

Code review.

/**
* The name of the form field direction (ltr or rtl).
*
* @var string
* @since 3.2
*/
protected $dirname;

Syntax should be name.dir but incorrectly changed in 3f4285e

@brianteeman
Copy link
Contributor

I dont think this is correct. see

// Set the dirname.
$dirname = ($dirname === 'dirname' || $dirname === 'true' || $dirname === '1');
$this->dirname = $dirname ? $this->getName($this->fieldname . '_dir') : false;

@QuyTon QuyTon marked this pull request as draft January 27, 2025 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants