Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Update all dependencies #44814

Merged
merged 5 commits into from
Feb 6, 2025
Merged

[5.3] Update all dependencies #44814

merged 5 commits into from
Feb 6, 2025

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Feb 3, 2025

Updates the dependencies.

@joomla-cms-bot joomla-cms-bot added Composer Dependency Changed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev labels Feb 3, 2025
@richard67
Copy link
Member

@laoneo It seems the php-cs-fixer update causes some PHPCS error in Drone, very likely due to a new rule or a bug fix in the fixer: https://ci.joomla.org/joomla/joomla-cms/81812/1/7

   1) build/update_fido_cache.php (blank_line_after_opening_tag)
      ---------- begin diff ----------
--- /drone/src/build/update_fido_cache.php
+++ /drone/src/build/update_fido_cache.php
@@ -1,4 +1,5 @@
 <?php
+
 /**
  * @package        Joomla.Build
  *

      ----------- end diff -----------

Found 1 of 2548 files that can be fixed in 57.970 seconds, 42.00 MB memory used

@richard67
Copy link
Member

The composer update of "joomla/database" brings a new feature (implemented by me in the framework) that you can use custom port numbers in the database host name with PostgreSQL as you already can do with MySQL or MariaDB. Maybe that should be noted for the release announcement?

@richard67
Copy link
Member

Now Drone fails with the "prepare_system_tests" step https://ci.joomla.org/joomla/joomla-cms/81820/1/21 :

+ mv cypress.config.dist.mjs cypress.config.mjs
+ npx cypress install
Unexpected token '.'

Possibly related to the cypress update?

@brianteeman
Copy link
Contributor

This is only updating the dependencies withing the restrictions set in the json which may not be sufficient

@heelc29
Copy link
Contributor

heelc29 commented Feb 3, 2025

Possibly related to the cypress update?

Yes, same like here: #44675 (comment)

We could try to use joomlaprojects/docker-images:cypress8.1 also for prepare_system_tests step

@laoneo laoneo mentioned this pull request Feb 6, 2025
4 tasks
@HLeithner HLeithner merged commit 7734d0e into joomla:5.3-dev Feb 6, 2025
3 checks passed
@HLeithner
Copy link
Member

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Composer Dependency Changed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants