Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Fields: Add warning to Finder option about information disclosure #3040

Closed
jgerman-bot opened this issue Oct 18, 2023 · 0 comments · Fixed by #3041
Closed

Custom Fields: Add warning to Finder option about information disclosure #3040

jgerman-bot opened this issue Oct 18, 2023 · 0 comments · Fixed by #3041
Assignees
@tecpromotion
Labels
core language change Joomla! 5.x

Comments

@jgerman-bot
Copy link

New language relevant PR in upstream repo: joomla/joomla-cms#42111 Here are the upstream changes:

Click to expand the diff! 
diff --git a/administrator/components/com_fields/forms/field.xml b/administrator/components/com_fields/forms/field.xml
index e688ff6eae965..88157e4abbf3e 100644
--- a/administrator/components/com_fields/forms/field.xml
+++ b/administrator/components/com_fields/forms/field.xml
@@ -342,6 +342,7 @@
 					name="searchindex"
 					type="list"
 					label="COM_FIELDS_FIELD_SEARCHINDEX_LABEL"
+					description="COM_FIELDS_FIELD_SEARCHINDEX_DESC"
 					default="0"
 					validate="options"
 					>
diff --git a/administrator/language/en-GB/com_fields.ini b/administrator/language/en-GB/com_fields.ini
index 0e8ba00000bee..17b2febfe08e9 100644
--- a/administrator/language/en-GB/com_fields.ini
+++ b/administrator/language/en-GB/com_fields.ini
@@ -58,6 +58,7 @@ COM_FIELDS_FIELD_RENDEROPTIONS_HEADING="Display Options"
 COM_FIELDS_FIELD_REQUIRED_LABEL="Required"
 COM_FIELDS_FIELD_SAVE_SUCCESS="Field saved"
 COM_FIELDS_FIELD_SEARCHINDEX_BOTH="Make searchable and add as taxonomy"
+COM_FIELDS_FIELD_SEARCHINDEX_DESC="Warning: When 'Make searchable' is selected, content from the field is indexed with the viewing permissions of the content item. This might lead to unexpected information disclosure."
 COM_FIELDS_FIELD_SEARCHINDEX_DONT="Don't make searchable"
 COM_FIELDS_FIELD_SEARCHINDEX_LABEL="Search Index"
 COM_FIELDS_FIELD_SEARCHINDEX_SEARCHABLE="Make searchable"
tecpromotion added a commit to tecpromotion/joomla that referenced this issue Oct 18, 2023
@tecpromotion
translation
70de2ff 
fix joomlagerman#3040
@tecpromotion tecpromotion mentioned this issue Oct 18, 2023
Merged
@tecpromotion tecpromotion linked a pull request Oct 18, 2023 that will close this issue
Custom Fields: Add warning to Finder option about information disclosure #3041
Merged
heelc29 pushed a commit that referenced this issue Nov 4, 2023
@tecpromotion
[5.0] Custom Fields: Add warning to Finder option about information d…
be85c20 
…isclosure (#3041)

* add new string

* translation

fix #3040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tecpromotion tecpromotion

Labels
core language change Joomla! 5.x
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom Fields: Add warning to Finder option about information disclosure tecpromotion/joomla
4 participants
@tecpromotion @zero-24 @jgerman-bot @heelc29