Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching the dependancy from ActiveRecord::Base to ActiveModel::Model breaks support for Rails 3 apps #147

Closed
EduardoBautista opened this issue Jun 20, 2016 · 5 comments
Closed

Switching the dependancy from ActiveRecord::Base to ActiveModel::Model breaks support for Rails 3 apps #147

EduardoBautista opened this issue Jun 20, 2016 · 5 comments

Comments

@EduardoBautista
Copy link

Not sure if this was intentional or not.
@joost
Copy link
Owner

joost commented Jun 20, 2016

Certainly not :)
Isn't ActiveModel included in ActiveRecord base?

Sent from my iPhone

On 20 Jun 2016, at 20:02, Eduardo Bautista notifications@github.com wrote:

Not sure if this was intentional or not.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@EduardoBautista
Copy link
Author

Only starting in Rails 4.

@wvanheerde
Copy link

Running into the same issue now. ActiveModel is only there since Rails 4. Is it possible for you to have a look at this?

@joost
Copy link
Owner

joost commented Feb 8, 2017

Feel free to fix and send a pull request :)

wvanheerde pushed a commit to wvanheerde/phony_rails that referenced this issue Feb 8, 2017
Fix Rails 3 compatibility in issue joost#147
3c1b9cb
joost pushed a commit that referenced this issue Feb 8, 2017
Merge pull request #156 from wvanheerde/master
a68e80b 
Fix Rails 3 compatibility in issue #147
@joost
Copy link
Owner

joost commented Feb 8, 2017

v0.14.5

@joost joost closed this as completed Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joost @EduardoBautista @wvanheerde