You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The name PhonyRails.default_country_code suggests that it is a fallback, not an enforcement (eg. like it would be if called PhonyRails.country_code)
Given a valid phone number, even if with a locale different from the default country_code, I would assume it is expected that plausible_number? would return true.
Edit: I just read about enforce_record_country: false, but I would ask you to consider the redesign of the interface of PhonyRails to make it more explicit on what validation it makes. plausible_number? is too broad and gives an erroneous idea of the validation logic it performs.
The text was updated successfully, but these errors were encountered:
With Finnish a valid phone number, while having a International code - Works as expected
With default country code DE, the valid Finnish number with international code is deemed implausible by PhonyRails but not Phony.
The name
PhonyRails.default_country_code
suggests that it is a fallback, not an enforcement (eg. like it would be if calledPhonyRails.country_code
)Given a valid phone number, even if with a locale different from the default country_code, I would assume it is expected that
plausible_number?
would return true.Edit: I just read about
enforce_record_country: false
, but I would ask you to consider the redesign of the interface of PhonyRails to make it more explicit on what validation it makes.plausible_number?
is too broad and gives an erroneous idea of the validation logic it performs.The text was updated successfully, but these errors were encountered: