Don't re-parse country codes YAML file every time it's needed. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joost
pushed a commit
that referenced
this pull request
Aug 19, 2015
Don't re-parse country codes YAML file every time it's needed.
|
This is in 0.12.10. |
|
Thanks! |
|
Awesome. I've been meaning to do this. I realized I forgot to add that after I submitted the PR. Thanks for getting to it before me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#109 added a country codes YAML file in order to remove the dependency on the
countriesgem. This is all well and good, but the current implementation reloads and re-parses that file every time the hash is needed. This potentially triggers reloading/parsing every time a phone number is normalized which adds a huge amount of unnecessary disk and CPU overhead to normalization.This patches adds a simple cache for that hash.