Fix code example in README to match description #167
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description for the code example says:
but the code example is still validating the raw input. This example "works" as long as the user enters a US number since the validation defaults to "US", but breaks if a an "IT" number is entered, for example.
Also, since we're validating the already normalized phone number, I don't think providing the "normalized_country_code" option is useful.
EDIT:
I added commit e44e76e because I'm guessing in the most common use case people don't want their records to be valid if the user enters a random string like "whatever", but also don't want to force a phone number - if they do, they should validate that the "phone_number" is present.