Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: "Hide application menus when showing menu bar items" option doesn't work in some apps. #60

Closed
1 task done
maxoliinyk opened this issue May 14, 2024 · 9 comments
Labels
Bug Something isn't working

Comments

@maxoliinyk
Copy link

Check existing issues

  • I have checked existing issues and believe that my issue is not a duplicate

Description

"Hide application menus when showing menu bar items" doesn't work in some apps.

For example, this issue appears every time in Arc browser

Steps to Reproduce

  1. Open Arc (example)
  2. Expand menubar
  3. See the issue

Ice Version

0.8.0

macOS Version

14.4.1

Screenshots

Expanded menubar in Arc

Expanded menubar in Music

@maxoliinyk maxoliinyk added the Bug Something isn't working label May 14, 2024
@jordanbaird
Copy link
Owner

I suspect this is due to the new "cooperative" style of app switching in macOS 14. Ice hides an application's menus by activating itself to show its own empty menu. Prior to macOS 14, apps could force their activation without needing to consult any other process. Now, they essentially have to "ask" the currently active app if it wants to give up its active status. Unfortunately, I'm not sure there's anything we can do about this, unless Apple decides they want to change this behavior.

@validatedev
Copy link

I just want to say something about the issue. The problem does not happen with Bartender 5, so I think there should be a way to implement that.

@validatedev
Copy link

Here is the screen recording with Bartender 5.0.49. As you can see, it works without any issues.
I think it's better to keep the issue open, maybe someone can find a solution for it.
@jordanbaird

Screen.Recording.2024-06-09.at.18.45.07.mov

@jordanbaird
Copy link
Owner

@validatedev noted. I'll reopen the issue.

@validatedev
Copy link

@jordanbaird with 0.10.3 it is worse. I cannot see any of the underflow elements.

I cannot use screen recording as it solves the issue as you can see :) Hence, I did the recording via my phone.

IMG_1257.MOV

@jordanbaird
Copy link
Owner

@validatedev I think I know what's going on. 0.10.3 introduced some changes to how the application menu frame is calculated, but code that checks whether the application menus need to be hidden wasn't updated to reflect the change. Should be a relatively easy fix.

@jordanbaird jordanbaird reopened this Jul 21, 2024
@validatedev
Copy link

@jordanbaird Perfect! Looking forward to trying the new build to verify the fix then :)

@jordanbaird
Copy link
Owner

Above is a temporary fix that should return the previous behavior. This implementation has some flawed logic to begin with, so at some point, I will be doing a full rewrite of the feature.

jordanbaird added a commit that referenced this issue Jul 23, 2024
@validatedev
Copy link

Apologies for missing the notification earlier. I'm glad to hear about the temporary fix and appreciate your efforts in addressing the issue. Thank you for keeping me updated. Looking forward to the full update when it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants