plat-imx: psci: implement clock-gated cluster idle state #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
jordanrh1
commented
Jun 12, 2018
jordanrh1
commented
- Implement WAIT mode with A7 clocks disabled
- Uses PSCI OS-initiated mode, extended state ID format, and ARM FFH
- Implement WAIT mode with A7 clocks disabled - Uses PSCI OS-initiated mode, extended state ID format, and ARM FFH
jordanrh1
commented
Jun 12, 2018
| @@ -201,8 +201,52 @@ | |||
| #error "CFG_MX6/7 not defined" | |||
| #endif | |||
|
|
|||
| /* SNVS */ | |||
There was a problem hiding this comment.
I think these definitions can be removed
jordanrh1
commented
Jun 12, 2018
|
|
||
| #define LPM_STATE_ALL_OFF \ | ||
| (LPM_MODE_WAIT | LPM_STOP_ARM_CLOCK | LPM_POWER_DOWN_CORES | \ | ||
| LPM_POWER_DOWN_SCU | LPM_POWER_DOWN_L2) |
There was a problem hiding this comment.
Not implemented. Remove
jordanrh1
commented
Jun 12, 2018
| DMSG("ID = %d\n", id); | ||
| if (id == 1) { | ||
| if (soc_is_imx7ds()) | ||
| return imx7d_lowpower_idle(power_state, entry, |
There was a problem hiding this comment.
imx7d_lowpower_idle [](start = 10, length = 19)
Where is this implemented?
jordanrh1
commented
Jun 12, 2018
| #define LPM_POWER_DOWN_CORES BIT(3) | ||
| #define LPM_POWER_DOWN_SCU BIT(4) | ||
| #define LPM_POWER_DOWN_L2 BIT(5) | ||
| #define LPM_INITIATING_CORE BIT(6) |
There was a problem hiding this comment.
All changes to this file probably need to move to cpuidle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.