add FPM::Util.execmd and fix python_spec.rb #1091
Conversation
|
I might be missing something but this looks a bit more like it's replacing what the safesystem wrapper is doing, maybe better to update/patch it for the extra functionality? |
|
I can't imagine how to provide special argument with the input string (for stdin) to safesystem, as its interface is and all args are treated as command-line arguments (except the first, which is a command name). I think, |
|
See 7b2d139 |
| django_bindir = %x{python -c 'from distutils.sysconfig import get_config_var; print(get_config_var("BINDIR"))'}.chomp | ||
| django_bindir = nil | ||
| # Determine, where 'easy_install' is going to install scripts | ||
| execmd('python', code_easy_install_default_script_dir) do |code,out,err| |
There was a problem hiding this comment.
As an alternative, you could include this python script in fpm similar to the way the python package support already does this --
python code and how it's invoked in fpm.
Since this is just for a test, the python code could live in a file in spec/fixtures/ somewhere (common in other similar ruby projects) and you can invoke safesystem("python spec/fixtures/default_script_dir.py") possibly capturing the output to a file like done here
Thoughts?
There was a problem hiding this comment.
I think, it may be good to leave execmd as, in opposite to safesystem* ones, it provides all standard communication channels to the executed command (stdin, stdout, stderr, exit_status). As you may se, I managed to implement both versions of safesystem* on top of execmd. I'm ok with moving the python code to fixture file (this could push me to organize it little bit better), but the actuall script consists of two pieces -- definition of a class and a code that uses this class. I think, the usage code (second part) is not worth giving it a fixture (it's a very small piece of code, and I don't think it's reusable), but hopefully it can be just passed to python interpreter via CLI.
ptomulik
force-pushed
the
fix/python_spec
branch
2 times, most recently
from
5eced2e to
69dfd8e
Compare
|
So, I made changes, according to previous proposition. The new |
|
Looks good to me! |
ptomulik
force-pushed
the
fix/python_spec
branch
from
69dfd8e to
a2dfa78
Compare
| # Determine default value of a given easy_install's option | ||
| def easy_install_default(option) | ||
| result = nil | ||
| execmd({:PYTHONPATH=>"#{example_dir}"}, 'python', :stderr=>false) do |stdin,stdout| |
There was a problem hiding this comment.
Using "example_dir" here may look little-bit out of context, but it should be fine as long as the function is used within the describe FPM:Package::Python... block.
|
Specs are passing with this PR, so I will merge. |
add FPM::Util.execmd and fix python_spec.rb
Created mainly to fix the issue spotted here.