Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create FreeBSD packages with correct architecture #2064

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Create FreeBSD packages with correct architecture #2064

merged 1 commit into from
Sep 12, 2024

Conversation

davidnewhall
Copy link
Contributor

@davidnewhall davidnewhall commented Aug 8, 2024 •
edited
Loading

  • Sets (hardcodes) name of OS as FreeBSD
  • Allows specifying the FreeBSD version the package is for, defaults to 13 and allows all or noarch.
  • Correctly honors --architecture input.
  • Fixes Freebsd - wrong architecture #1880
  • Tested on Freebsd 13. Using --architecture as 12, 13, and *.
    • Using 12 correctly produces a wrong architecture message.
    • Using 13 and * work. Meaning pkg add does not return error.

@davidnewhall davidnewhall mentioned this pull request Aug 8, 2024
Open
jordansissel
jordansissel approved these changes Sep 12, 2024
View reviewed changes
Copy link
Owner

@jordansissel jordansissel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a freebsd machine to test on at this time, but the code change looks ok, and given the other two 👍 on the PR, I'm ok to merge.

@jordansissel jordansissel merged commit d81a1ad into jordansissel:main Sep 12, 2024
@anantshri anantshri mentioned this pull request Dec 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jordansissel jordansissel jordansissel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Freebsd - wrong architecture
2 participants
@davidnewhall @jordansissel