Add support for .timer units to --deb-systemd #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the change, when using an option --deb-systemd myunit.timer, the actual file created would be /lib/systemd/system/myunit.timer.service Because of that, systemd would then not find the timer. With this change, the correct extension is extracted from the file, defaulting to .service. Typically, there would be two files for installing a timer: --deb-systemd myunit.service (where .service could be omitted) and --deb-systemd myunit.timer So that the .timer references a .service file.
jordansissel
requested changes
Sep 12, 2024
|
I'll merge as-is and make the exception change after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the change, when using an option --deb-systemd myunit.timer, the actual file created would be
/lib/systemd/system/myunit.timer.service
Because of that, systemd would then not find the timer.
With this change, the correct extension is extracted from the file, defaulting to .service.
Typically, there would be two files for installing a timer:
--deb-systemd myunit.service (where .service could be omitted) and --deb-systemd myunit.timer
So that the .timer references a .service file.
Fixes #1978