Update rpm.rb #2082
Update rpm.rb #2082
Conversation
Fix how buildroot is specified to better conform with the rpmbuild CLI. The old way was failing with `File not found` errors.
|
This should fix #2076 |
| @@ -473,7 +473,7 @@ def output(output_path) | |||
| args += ["--define", "dist .#{attributes[:rpm_dist]}"] if attributes[:rpm_dist] | |||
|
|
|||
| args += [ | |||
| "--define", "buildroot #{build_path}/BUILD", | |||
There was a problem hiding this comment.
I would consider doing both just to be on the safe side
There was a problem hiding this comment.
Not a bad idea, I've put the older argument back in.
Leave old `--define` argument in place for `buildroot`
|
@jordansissel Sorry to ping you directly, but this fix would be needed to make fpm work on Fedora 41 which is now the default fedora since couple of weeks. Would you mind having a look at this proposal ? |
|
@jordansissel ping again ;) |
|
Tests pass so it’s probably ok to merge! Thanks for improving fpm :) |
|
Thanks. Since this issue is effectively breaking fedora users since the release of fedora 41, would it be possible to also cut a release and publish the resulting gem ? This way fedora users will no longer need to manually patch the gem installation. |
|
@Romain-Geissler-1A I began working on the release tonight, part of which is attending to a bunch of open PRs; a completed release will happen at some point after that work is done. |
|
fpm v1.16.0 is released :) |
Fix how buildroot is specified to better conform with the rpmbuild CLI. The old way was failing with
File not founderrors.