Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use java.nio to open files with file_share_delete permissions #22

Merged
merged 6 commits into from
Jan 9, 2014

Conversation

edwinf
Copy link
Contributor

@edwinf edwinf commented Nov 27, 2013

  • Will only use the java extension if running on windows and inside of JRuby.
  • This PR is also a rollup of Add logic for a better windows file identifier in tail.rb #19, which has all of the details around better file identifiers to use with the since.db records and how to prevent always starting over.
  • I'm not sure this is the best approach for the stand alone file watch piece, but I've been patching logstash with these changes since mid summer and they work great on windows for us and for those I've helped apply the same patches. I'd be happy to change whatever is asked to get this applied to the main branch.

@bwmeier
Copy link
Contributor

bwmeier commented Dec 3, 2013

👍 This desperately needs to be included in the gem for logstash.

@jordansissel
Copy link
Owner

Indeed, I'll attend to this PR ssoon. Sorryf or the delays :)

jordansissel added a commit that referenced this pull request Jan 9, 2014
Use java.nio to open files with file_share_delete permissions
@jordansissel jordansissel merged commit e0dfb20 into jordansissel:master Jan 9, 2014
@jordansissel
Copy link
Owner

Just going to merge as-is; given the positive feedback on this patch and my lack of time for really testing it, I think it's OK to merge.

@marlonbernardes
Copy link

Thanks, @edwinf. It kinda saved my life. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants