Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancing sincedb flushing #29

Closed

Conversation

bdanziger
Copy link

enhancing sincedb to properly flush when files have been read from, while preserving the sincedb_write_interval

@bdanziger
Copy link
Author

Today, the watch.rb only returns to the caller after file creation, or modification. So, if the caller needs to do something, you are out of luck. Example : tail.rb, uses sincedb_write_interval and only writes once during the interval, even though there might have been read events after the sincedb flush but before completion of the interval. So, returning back to tail.rb would allow the tail to flush when the interval expires. Additionally, I moved the @sincedb_last_write to the routine that actually does the write. It is the only routine that really knows when it is written and should control this variable.

@guyboertje
Copy link
Contributor

I intend to bear this in mind when I refactor the whole sincedb behaviour in response to #75

@guyboertje guyboertje closed this Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants