Implement auto throttling #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both have different caracteristics and should be treated differently.
parse_page_headers is the public one that takes the Headers struct.
In the case that the remote does not provide rate limiting headers, then update the response ones based on gitar defaults.
local_cache is a flag that is set when the response is retrieved from the local cache. The use case is to disable throttling when the response is retrieved from the local cache.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
==========================================
- Coverage 86.60% 86.21% -0.39%
==========================================
Files 68 69 +1
Lines 16453 16870 +417
Branches 16453 16870 +417
==========================================
+ Hits 14249 14545 +296
- Misses 2023 2138 +115
- Partials 181 187 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several key improvements and refactorings related
to HTTP response handling, throttling, and caching:
Link and rate limit headers are now encapsulated in dedicated structures for
improved readability and usability. The responses have been split into
HttpResponse and ShellResponse, providing better separation of concerns.
A new throttle module has been added, providing a strategy for auto throttling
Local cache responses are excluded from throttling to optimize performance.