complete scipy.fft.dct, and add relevant type aliases
#118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
changed the title
scipy.fft._realtransforms.dctscipy.fft._realtransforms.dct and add relevant type aliases
jorenham
requested changes
Oct 20, 2024
There was a problem hiding this comment.
Thank you for this! Every improvement helps, so it's no problem to specifically target a single function like this 😄
I left a few suggestions on how to improve this.
The reason a can't accept this as-is, is because the current dct annotations could lead to incorrectly inferred types and false positives. See my inline dct comment for why this is.
jorenham
changed the title
scipy.fft._realtransforms.dct and add relevant type aliasesscipy.fft.dct, and add relevant type aliases
jorenham
reviewed
Oct 21, 2024
jorenham
approved these changes
Oct 21, 2024
Merged
|
Thanks, @Avasam! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the only function used by https://github.com/Toufool/AutoSplit, and I'd gladly replace my local https://github.com/Toufool/AutoSplit/tree/9588834e0881e8c09b449954f4c5c24f0e15bd14/typings/scipy for a community-based one.
I've also added and applied type aliases for "DCT type" and "normalization mode"
I'm not 100% certain about the numpy generic types.