-
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
complete scipy.fft.dct
, and add relevant type aliases
#118
Conversation
scipy.fft._realtransforms.dct
scipy.fft._realtransforms.dct
and add relevant type aliases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this! Every improvement helps, so it's no problem to specifically target a single function like this 😄
I left a few suggestions on how to improve this.
The reason a can't accept this as-is, is because the current dct
annotations could lead to incorrectly inferred types and false positives. See my inline dct
comment for why this is.
scipy.fft._realtransforms.dct
and add relevant type aliasesscipy.fft.dct
, and add relevant type aliases
Thanks, @Avasam! |
This is the only function used by https://github.com/Toufool/AutoSplit, and I'd gladly replace my local https://github.com/Toufool/AutoSplit/tree/9588834e0881e8c09b449954f4c5c24f0e15bd14/typings/scipy for a community-based one.
I've also added and applied type aliases for "DCT type" and "normalization mode"
I'm not 100% certain about the numpy generic types.