use fully qualified paths of cp, mv, etc. or command before invoking them

[jab]

I have common commands like cp, mv, etc. aliased to cp -i, mv -i, etc.

When I use fisherman, I see overwrite /Users/jab/.config/fisherman/fishfile? (y/n [n]) not overwritten.

I assume this is caused by fisherman referring to a command like cp as just cp, rather than as /bin/cp or command cp. This can cause problems if the user has the command aliased to pass other arguments (such as interactive mode, as above), since fisherman is assuming cp is the same thing as /bin/cp, it isn't. If so, any interest in fixing this? I think well-behaved shell scripts are supposed to use fully-qualified paths or use command to avoid this problem.

[daenney]

Using command is probably a good idea but if you're using Fish I'd recommend using abbreviations over aliases. They have the advantage of being automatically expanded on your shell (so the command you end up executing doesn't contain "hidden" options) and wouldn't mess with scripts like this.

[jab]

Thanks @daenney, switched to using abbr and glad to have another way to accomplish the same thing that doesn't get in the way of fisherman. And glad you agree it's worth using command in fisherman.

[ghost]

@jab You are absolutely right, so I have added it to the next milestone. I'll patch this ASAP and push after all tests pass and I see things to be working as they should.

[ghost]

• mkdir
• cp
• ln
• rm

[daenney]

Bash seems to have an unalias so you can remove aliases. It might be worth seeing if we can recreate that somehow so we can call that at the top/whenever we start a script and then not have to worry about the command invocations at all.

[daenney]

Oh ha, since aliases are just functions we could functions -e instead.

[ghost]

@daenney Yes, we would need to copy the function first, remove it and then define it again later.

[daenney]

Oh, bummer. I was hoping it could scope that to the script currently being executed.

[ghost]

scope that to the process currently being executed.

That's clever, and I wish it was like that too. But that trick only works for variables in Fish.

function foo
    set -l x 1
    begin
        set -l x 
    end
    echo $x # 1
end

[daenney]

In theory though, functions has -c which would allow you to copy the function to a backup and back but it would affect all other running sessions too which is unpleasant.

[ghost]

I think we need to command patch stuff like cp and rm first, to fix @jab's problem and probably the most common use case out there.

As for other commands like printf, git or make we should be able to spare them for the time being with little or no consequences.

[daenney]

I've updated it to call command on rm, ln, mkdir and mv.