Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Add deserialization of Bytes -> Decimal #1534

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion src/io/parquet/read/deserialize/simple.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

use crate::types::i256;
use crate::{
array::{Array, DictionaryKey, MutablePrimitiveArray, PrimitiveArray},
array::{Array, BinaryArray, DictionaryKey, MutablePrimitiveArray, PrimitiveArray},
datatypes::{DataType, IntervalUnit, TimeUnit},
error::{Error, Result},
types::{days_ms, NativeType},
Expand Down Expand Up @@ -230,6 +230,32 @@

Box::new(arrays) as _
}
(PhysicalType::ByteArray, Decimal(_, _)) => {
let pages = binary::Iter::<i32, _>::new(pages, DataType::Binary, chunk_size, num_rows);

let pages = pages.map(move |maybe_array| {
let array = maybe_array?;
let array_len = array.len();
let array = array.as_any().downcast_ref::<BinaryArray<i32>>().unwrap();
let values = (0..array_len)
.map(|i| {
let value = array.value(i);
let n = value.len();
if n > 16 {
return Err(Error::Overflow);
}
Ok(super::super::convert_i128(value, n))
})
.collect::<Result<Vec<_>>>();
let validity = array.validity().cloned();

PrimitiveArray::<i128>::try_new(data_type.clone(), values?.into(), validity)
});

let arrays = pages.map(|x| x.map(|x| x.boxed()));

Box::new(arrays) as _

Check warning on line 257 in src/io/parquet/read/deserialize/simple.rs

View check run for this annotation

Codecov / codecov/patch

src/io/parquet/read/deserialize/simple.rs#L234-L257

Added lines #L234 - L257 were not covered by tests
}
(PhysicalType::Int32, Decimal256(_, _)) => dyn_iter(iden(primitive::IntegerIter::new(
pages,
data_type,
Expand Down
6 changes: 6 additions & 0 deletions src/io/parquet/read/schema/convert.rs
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,12 @@
(_, Some(PrimitiveConvertedType::Bson)) => DataType::Binary,
(_, Some(PrimitiveConvertedType::Enum)) => DataType::Binary,
(_, Some(PrimitiveConvertedType::Utf8)) => DataType::Utf8,
(Some(PrimitiveLogicalType::Decimal(precision, scale)), _) => {
DataType::Decimal(*precision, *scale)

Check warning on line 146 in src/io/parquet/read/schema/convert.rs

View check run for this annotation

Codecov / codecov/patch

src/io/parquet/read/schema/convert.rs#L145-L146

Added lines #L145 - L146 were not covered by tests
}
(_, Some(PrimitiveConvertedType::Decimal(precision, scale))) => {
DataType::Decimal(*precision, *scale)

Check warning on line 149 in src/io/parquet/read/schema/convert.rs

View check run for this annotation

Codecov / codecov/patch

src/io/parquet/read/schema/convert.rs#L148-L149

Added lines #L148 - L149 were not covered by tests
}
(_, _) => DataType::Binary,
}
}
Expand Down
Loading