Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

use edition 2021 #769

Merged
merged 1 commit into from
Jan 17, 2022
Merged

use edition 2021 #769

merged 1 commit into from
Jan 17, 2022

Conversation

jimexist
Copy link
Contributor

No description provided.

@jorgecarleitao
Copy link
Owner

Thanks @jimexist! Could you check #571 ?

The context is that I was recommended to wait.

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #769 (0f8c6ff) into main (72f8363) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #769      +/-   ##
==========================================
- Coverage   71.06%   71.00%   -0.06%     
==========================================
  Files         316      316              
  Lines       16755    16733      -22     
==========================================
- Hits        11907    11882      -25     
- Misses       4848     4851       +3     
Impacted Files Coverage Δ
src/io/ipc/read/array/struct_.rs 71.42% <0.00%> (-5.72%) ⬇️
src/io/ipc/read/array/union.rs 53.65% <0.00%> (-4.88%) ⬇️
src/io/ipc/write/common.rs 90.10% <0.00%> (-1.16%) ⬇️
src/io/ipc/write/serialize.rs 65.46% <0.00%> (-1.09%) ⬇️
src/array/primitive/mutable.rs 85.40% <0.00%> (-0.43%) ⬇️
src/io/json_integration/read/array.rs 79.39% <0.00%> (-0.11%) ⬇️
src/io/parquet/read/nested_utils.rs 78.43% <0.00%> (+0.98%) ⬆️
src/io/avro/read/schema.rs 55.91% <0.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72f8363...0f8c6ff. Read the comment docs.

@jimexist
Copy link
Contributor Author

Thanks @jimexist! Could you check #571 ?

The context is that I was recommended to wait.

Thanks for the context.

2 months have passed and i believe 2021 edition should be widely adopted either way. But YMMV, there's no harm parking this one here.

@jorgecarleitao
Copy link
Owner

Cc @sundy-li , @ritchie46 , @sd2k - have you migrated? Would this be an issue?

@sundy-li
Copy link
Collaborator

Yes,databend is using edition 2021 now.

@ritchie46
Copy link
Collaborator

Polars is also on edition 2021.

@sd2k
Copy link
Contributor

sd2k commented Jan 17, 2022

Yep, same for the Grafana plugin SDK.

@jorgecarleitao jorgecarleitao merged commit b70483e into jorgecarleitao:main Jan 17, 2022
@jorgecarleitao
Copy link
Owner

Thanks everyone for your input, and @jimexist for the PR! Set sail, then!

@jimexist jimexist deleted the use-2021 branch January 18, 2022 00:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants