Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Error #181

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Improved Error #181

merged 1 commit into from
Aug 15, 2022

Conversation

jorgecarleitao
Copy link
Owner

Replaced Error::General and Error::External by Error::InvalidParameter and Error::FeatureNotSupported - General is not very insigthful and is not something the user can do much about.

Audited code for returning errors and adjusted them accordingly.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2022

Codecov Report

Merging #181 (2711aee) into main (ced2f52) will increase coverage by 0.31%.
The diff coverage is 24.54%.

@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   85.32%   85.63%   +0.31%     
==========================================
  Files          82       82              
  Lines        8108     8089      -19     
==========================================
+ Hits         6918     6927       +9     
+ Misses       1190     1162      -28     
Impacted Files Coverage Δ
src/deserialize/binary.rs 75.00% <0.00%> (ø)
src/deserialize/boolean.rs 72.22% <0.00%> (ø)
src/deserialize/fixed_len.rs 73.46% <0.00%> (ø)
src/deserialize/native.rs 63.63% <0.00%> (ø)
src/deserialize/utils.rs 89.77% <0.00%> (ø)
src/encoding/plain_byte_array.rs 84.00% <0.00%> (ø)
src/metadata/column_chunk_metadata.rs 69.51% <0.00%> (+1.65%) ⬆️
src/metadata/row_metadata.rs 40.00% <0.00%> (ø)
src/metadata/schema_descriptor.rs 91.39% <0.00%> (+1.92%) ⬆️
src/page/mod.rs 74.80% <0.00%> (+2.75%) ⬆️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants