-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added serde
support for RowGroupMetaData
.
#202
Conversation
Codecov ReportBase: 85.69% // Head: 85.69% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #202 +/- ##
=======================================
Coverage 85.69% 85.69%
=======================================
Files 84 84
Lines 8254 8254
=======================================
Hits 7073 7073
Misses 1181 1181
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This would add a significant dependency to this crate. Would it make sense to make this an optional feature under |
@jorgecarleitao refactor done, it is a feature now. |
use thrift for types in parquet_format_safe.
@jorgecarleitao Is there anything else needs to improve? |
serde
support for RowGroupMetaData
.
Awesome, thanks a lot! |
Is it ready to bump to 0.16.4? @jorgecarleitao |
We need to bump to 0.17 - there are breaking changes in main. Released :) |
use thrift for types in parquet_format_safe.
#200
it turns out that there are as many as 16 types that need to impl
De/Serialize
, so it is very troublesome to work it around outside.