Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled bitpacking default-features and upgraded to edition 2021 #93

Merged
merged 2 commits into from
Mar 12, 2022

Conversation

light4
Copy link
Contributor

@light4 light4 commented Mar 12, 2022

reduce build time

@codecov-commenter
Copy link

Codecov Report

Merging #93 (de02007) into main (aaef5fe) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
- Coverage   67.62%   67.58%   -0.04%     
==========================================
  Files          69       69              
  Lines        3830     3829       -1     
==========================================
- Hits         2590     2588       -2     
- Misses       1240     1241       +1     
Impacted Files Coverage Δ
src/statistics/binary.rs 0.00% <0.00%> (-5.56%) ⬇️
src/encoding/delta_length_byte_array/encoder.rs 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aaef5fe...de02007. Read the comment docs.

@jorgecarleitao
Copy link
Owner

Thanks @light4 , well spotted improvements 👍

@jorgecarleitao jorgecarleitao merged commit dde253d into jorgecarleitao:main Mar 12, 2022
@jorgecarleitao jorgecarleitao added the enhancement New feature or request label Mar 12, 2022
dantengsky pushed a commit to datafuse-extras/parquet2 that referenced this pull request Apr 1, 2022
…ecarleitao#93)

* disable bitpacking default-features

* upgrade to edition 2021
@jorgecarleitao jorgecarleitao changed the title disable bitpacking default-features and upgrade to edition 2021 Disabled bitpacking default-features and upgraded to edition 2021 Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants