Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed LZ4 #95

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Fixed LZ4 #95

merged 1 commit into from
Mar 15, 2022

Conversation

jorgecarleitao
Copy link
Owner

LZ4 in parquet has two formats, but the LZ4 is not recommended (LZ4_RAW is the recommended). We were unable to read LZ4 due to using the decompressor of the new format with the outdated format.

This PR fixes this.

We will need a bump of the parquet-format to contain the new spec.

@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #95 (9769a3c) into main (dde253d) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
- Coverage   67.58%   67.58%   -0.01%     
==========================================
  Files          69       69              
  Lines        3829     3838       +9     
==========================================
+ Hits         2588     2594       +6     
- Misses       1241     1244       +3     
Impacted Files Coverage Δ
src/parquet_bridge.rs 23.17% <25.00%> (+0.09%) ⬆️
src/compression.rs 88.23% <90.90%> (-1.48%) ⬇️
src/metadata/column_chunk_metadata.rs 52.94% <100.00%> (+0.94%) ⬆️
src/read/mod.rs 93.82% <0.00%> (+0.10%) ⬆️
src/statistics/fixed_len_binary.rs 3.22% <0.00%> (+3.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dde253d...9769a3c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants