Skip to content

Commit

Permalink
[video_player] Fix setWithOthers test (flutter#2970)
Browse files Browse the repository at this point in the history
  • Loading branch information
Chris Yang authored and jorgefspereira committed Oct 10, 2020
1 parent 971d5c6 commit e74b843
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
4 changes: 4 additions & 0 deletions packages/video_player/video_player/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.10.12+2

* Fix `setMixWithOthers` test.

## 0.10.12+1

* Depend on the version of `video_player_platform_interface` that contains the new `VideoPlayerOptions` class.
Expand Down
2 changes: 1 addition & 1 deletion packages/video_player/video_player/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Flutter plugin for displaying inline video with other Flutter
# 0.10.y+z is compatible with 1.0.0, if you land a breaking change bump
# the version to 2.0.0.
# See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0
version: 0.10.12+1
version: 0.10.12+2
homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player

flutter:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -579,11 +579,11 @@ void main() {
expect(colors.backgroundColor, backgroundColor);
});

test('setMixWithOthers', () {
test('setMixWithOthers', () async {
final VideoPlayerController controller = VideoPlayerController.file(
File(''),
videoPlayerOptions: VideoPlayerOptions(mixWithOthers: true));
controller.initialize();
await controller.initialize();
expect(controller.videoPlayerOptions.mixWithOthers, true);
});
}
Expand Down Expand Up @@ -656,6 +656,11 @@ class FakeVideoPlayerPlatform extends VideoPlayerApiTest {
void setVolume(VolumeMessage arg) {
calls.add('setVolume');
}

@override
void setMixWithOthers(MixWithOthersMessage arg) {
calls.add('setMixWithOthers');
}
}

class FakeVideoEventStream {
Expand Down

0 comments on commit e74b843

Please sign in to comment.