Add -fix flag for automatically fixing the pinentry symlink #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When installing gnupg, homebrew automatically configures the path of the pinentry binary to the `opt_bin` path of the formula instead of the symlink in `/usr/local/bin` https://github.com/Homebrew/homebrew-core/blob/08d0d1cc331d570a31d5ef89e695ad283c75d4f6/Formula/gnupg.rb#L54 this means that actual path returned by `gpgconf` ends up looking like: /usr/local/opt/pinentry/bin/pinentry. Fixing the symlink in `/usr/local/bin` doesn't always solve the issue because `gpgconf` is still reporting the `/usr/local/opt` path. The new flag changes automatically this symlink to point to pinentry-mac. I tried unsuccessfully to include this as part of the automatic Formula installation but it is not possible because during installation the formula cannot modify any external path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When installing gnupg, homebrew automatically configures the path of the pinentry binary to the
opt_binpath of the formula instead of the symlink in/usr/local/binthis means that actual path returned bygpgconfends up looking like:/usr/local/opt/pinentry/bin/pinentry.Fixing the symlink in
/usr/local/bindoesn't always solve the issue becausegpgconfis still reporting the/usr/local/optpath.The new flag will automatically change this symlink to point to pinentry-mac.
I tried unsuccessfully to include this as part of the automatic Formula installation but it is not possible because during installation the formula cannot modify any external path.