feat: fallback to pinentry-mac if no touchID #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There might be a situation when device has TouchID, but once the lid is closed `sensor.IsTouchIDAvailable()` returns false. It happens when you connect and external display to your laptop and have the lid closed. This commit adds a fallback scenario to call pinentry-mac when touchID is not available.
|
Hi @jorgelbg can you please review this one? |
|
Fixes #15 |
|
@troyanov Nice finding! and thank you for the contribution! I never considered the chance where people used pinentry-touchid with the laptop closed 😅 (looking back is kind of obvious that a lot of people use their laptop in clamshell mode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There might be a situation when device has TouchID, but once the lid is closed
sensor.IsTouchIDAvailable()returns false.It happens when you connect and external display to your laptop and have the lid closed.
This PR adds a fallback scenario to call pinentry-mac when touchID is not available.