Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydantic integration with Jedi 18 fix. #1895

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

gfederix
Copy link

PR Summary

First steps in to integration pydantic.
Jedi16 support has been removed.
Fixed work of Jedi18.
Removed python2 support.

Code reviews and suggestions are welcome. :)

PR checklist

Please make sure that the following things have been addressed (and check the relevant checkboxes):

  • Commits respect our guidelines
  • [ X] Tests are passing properly (see here on how to run Elpy's tests)

For new features only:

  • Tests has been added to cover the change
  • The documentation has been updated

@galaunay
Copy link
Collaborator

Oh my, that is a lot of commits :).

Is it ready to be tested and/or used ?

@gfederix
Copy link
Author

Oh my, that is a lot of commits :).

Is it ready to be tested and/or used ?

I broke get_docstring. And this is only visible in emacs tests. ;-( Looks like other code works, but I need time to fix broken before merging. And probably write a regression test. I think I'll fix it in early April.

I can also merge my commits into one, if it's convenient.

@galaunay
Copy link
Collaborator

Well, I am afraid the test suite is not in a good state at the moment. Some tests fails even on the master branch, so nobody should focus too much on them ATM...
We can squash the commits in due time, before merging,

@galaunay galaunay force-pushed the master branch 3 times, most recently from c4a2564 to d974e00 Compare June 30, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants