Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mariadb dumps with newlines #20

Merged
merged 8 commits into from
Dec 28, 2023

Conversation

josacar
Copy link
Owner

@josacar josacar commented Dec 28, 2023

Closes #19

Changes:

  • Read full statements instead of lines to support new MariaDB dumps
  • Deleted single-use moduels
  • Use abstract class to define engines
  • Get rid of parse_copy_statement lambda and use macro to detect proper type when dispatching method calls
In spec/triki_spec.cr:120:18

120 | scaffolder.scaffold(dump, output)
                 ^
Error: instantiating 'Triki#scaffold(IO::Memory, IO::Memory)'


In src/triki.cr:83:21

83 | database_helper.generate_config(self, config, input_io, output_io)
                     ^
Error: instantiating 'Triki::Base+#generate_config(Triki, Hash(String, Hash(String, Hash(Symbol, Array(Regex) | Array(String) | Bool | Int32 | Proc(Hash(String, Int32 | String | Nil), (Int32 | String | Nil)) | Proc(Hash(String, Int32 | String | Nil), Bool) | Proc(String) | Range(Int32, Int32) | String | Symbol) | Symbol) | Symbol), IO::Memory, IO::Memory)'


In src/triki/config_scaffold_generator.cr:9:24

9 | table_data = parse_copy_statement(line)
                 ^
Error: undefined method 'parse_copy_statement' for Triki::SqlServer

@josacar josacar merged commit 8e0eb12 into master Dec 28, 2023
3 checks passed
@josacar josacar deleted the support-mariadb-dumps-with-newline branch December 28, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple-row INSERT statements and AWS RDS/Mysql 8
1 participant