-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Pass validation severity into UI #416
Conversation
Thanks Andrew! I'll review your PR next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for working out this solution Andrew, this looks good. I made a couple of inline comments. Can you have a look at those?
Thanks for the updates, this looks really good, both the code and the UI! |
I see there is a linting issue, I'll fix that right after merging. |
Published now in |
This PR addresses the following discussion and issues:
Allows the validation error severity to be
warning
(yellow),error
(red), orinfo
(blue).If the validation error table is collapsed, it uses the first validation error to determine the color to show.
If the validation error table is opened, each validation error will be the assigned color from the validator.
Also updated the hover color for each validation error.