Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong hole on the corner? #34

Closed
hacktivateit opened this issue Feb 4, 2021 · 2 comments
Closed

Wrong hole on the corner? #34

hacktivateit opened this issue Feb 4, 2021 · 2 comments
Assignees
Labels
bug Something isn't working v2 version 2

Comments

@hacktivateit
Copy link

hacktivateit commented Feb 4, 2021

I know nothing about pcb design so i'm just reporting an issue that JLCPCB faced and kindly reported back to me.

I sent JLCPCB the gerber files for v2 and they sent me this mail

As shown below, do you need to cut out the circle at the arrow on PCB? It is in KO layer.

Or we can delete it to proceed?
627342bf6d72445d9fb6ecdf4e04789e

Is this an issue?

@hacktivateit hacktivateit changed the title Wrong hole? Wrong hole on the corner? Feb 4, 2021
@josefadamcik
Copy link
Owner

josefadamcik commented Feb 4, 2021 via email

@josefadamcik josefadamcik self-assigned this Feb 4, 2021
@josefadamcik josefadamcik added bug Something isn't working v2 version 2 labels Feb 4, 2021
@josefadamcik josefadamcik mentioned this issue Feb 4, 2021
@josefadamcik
Copy link
Owner

Fixed int the KiCad files, gerber files and crated a new version with fixed files at https://github.com/josefadamcik/SofleKeyboard/releases/tag/v2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2 version 2
Projects
None yet
Development

No branches or pull requests

2 participants