Add support for fine-grained tokens #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add flags and example for fine-grained tokens
srl295
reviewed
Apr 7, 2023
| -t TOKEN, --token TOKEN | ||
| -f TOKEN_FINE, --token-fine TOKEN | ||
| fine-grained personal access token | ||
| -t TOKEN_CLASSIC, --token-classic TOKEN |
There was a problem hiding this comment.
Suggested change
| -t TOKEN_CLASSIC, --token-classic TOKEN | |
| -t TOKEN_CLASSIC, --token TOKEN |
don't rename the old arg
Comment on lines
+371
to
+373
| if args.token_classic.startswith(_path_specifier): | ||
| args.token_classic = open(args.token_classic[len(_path_specifier):], | ||
| 'rt').readline().strip() |
There was a problem hiding this comment.
need to support this ( file:// ) for fine grained tokens too. otherwise you have to include the PAT on the command line.
|
Mind rebasing this and responding to the above feedback? |
|
What would be needed for this to be merge-able, @josegonzalez? Evaluating continuing the contribution, so it can be included in code base. Regarding the existing flags, my assumption would be that being backwards compatible (not altering existing) would be preferrable. I also see comments that address certain errors if the fine grained token does not give enough permissions. I'm not sure I would address this as a first step. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the beta fine-grained personal access tokens (PAT)
Changes implemented
token_finewith the new-fflag to support the new token format.tokencommand line argument intotoken_classic, keeping the flag-tIssues addressed
This PR addresses #205