feat: Enable Fish's git <command> completion on simple wrappers
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch aims to bring Fish's awesome completion to everyday git wrappers that pass `$argv` to the command they call. Affected commands: - `stage` -> wraps `git add` - `unstage` -> wraps `git reset` - `show` -> wraps `git show` - `commit` -> wraps `git commit` - `push` -> wraps `git push` - `pull` -> wraps `git pull`
|
Good idea! |
joseluisq
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: This patch aims to bring Fish's awesome completion to everyday git wrappers that pass
$argvto the command they call.Motivation: I love this plugin and it's part of the first few things I always put on all of my fresh Linux installs, but it has always bugged me how it doesn't provide users with
git <command>completions on some shorthands that I use daily and accept any of<command>'s flags/options. Fish'sfunctiondirective has an option to specify that it's a wrapper, I figured it was only some of Gitnow's wrappers make use of it.Affected commands:
stage-> wrapsgit addunstage-> wrapsgit resetshow-> wrapsgit showcommit-> wrapsgit commitpush-> wrapsgit pushpull-> wrapsgit pullHave a good day, and thanks for the excellent workflow QOL you've provided me and many users with!
PS: Seems my automatic whitespace cleanup found a trailing space at line 376... Oh well. ¯\_(ツ)_/¯