Linux/Darwin arm64 cross-compiling support for x86_64 Docker image
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the Docker image such that it can be successfully built and used as either a linux/amd64 image or a linux/amd64 image. The Makefile has been given a new `buildx` command to utilise Docker's multi-platorm building capability to build and push (!!!) both images. This is separate from the `build` command as since one of the arch's will be compiled under emulation, and therefore `buildx` can take a long time to complete (took ~2h on my 8 core old gaming laptop). Some other things added along the way: * Makefile take REPOSITORY and TAG arguments, such that building local images and testing is easier to do. Out of scope: * Haven't integrated it with GitHub actions, as I'm not that familiar with it, but figured this was a good first step. Known issues: * For arm64 images, can't get linux-musl test in `make test` to pass. Wondering if we need to explicitly install the amd64 version via apt? Have yet to experiment. Cross compiling to `x86_64-apple-darwin` works perfectly though on arm64 host. Work on #12
- linux gcc: gcc-aarch64-linux-gnu - rust toolchain: aarch64-unknown-linux-gnu
- rust toolchain: aarch64-unknown-linux-musl
joseluisq
changed the title
arm64 cross-compiling support from x86_64arm64 cross-compiling support for x86_64 Docker image
joseluisq
force-pushed
the
dockerfile-refactoring
branch
from
1cd2c43 to
60fe50d
Compare
joseluisq
force-pushed
the
dockerfile-refactoring
branch
from
60fe50d to
28d67a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work done on #13. This PR adds support for cross-compiling Linux/Darwin
arm64apps from ax86_64Docker image.It also improves Dockerfile layers caching and cross-compilation tests.