New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with dummy app from addons #121

Merged

josemarluedke merged 1 commit into josemarluedke:main from NullVoxPopuli:fix-cacheKeyForTree

Dec 17, 2021

Contributor

NullVoxPopuli commented Dec 17, 2021

This fixes all the issues I had with both


          Fix issue with dummy app from addons

b5315f0

NullVoxPopuli commented

View reviewed changes

packages/ember/src/index.ts

-                        ?.join(',');
-                      return cacheKeyForTree(treeType, this, [sources]);
+                    case 'app':
+                    case 'addon': {

Contributor Author

NullVoxPopuli Dec 17, 2021

without the addon entry, I'd get:

josemarluedke approved these changes

View reviewed changes

josemarluedke merged commit 1fccc51 into josemarluedke:main

josemarluedke added the Type: Bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels