Skip to content
This repository has been archived by the owner on Nov 29, 2021. It is now read-only.

connect to 127.0.0.1 instead of localhost #7

Merged
merged 2 commits into from
Jan 8, 2018

Conversation

nicolas-schmitt
Copy link

Hi there !
First off, thanks for this awesome module.

I'm using it at work and localhost actually resolves to a different ip than '127.0.0.1'
Because of this, the client is unable to connect to the server.

This can be solved by specifying the host in the 'connect' statement.

@josephfrazier josephfrazier merged commit b4dd7d0 into josephfrazier:master Jan 8, 2018
@josephfrazier
Copy link
Owner

Thanks @nicolas-schmitt, I'm glad to hear you find this project useful! I changed the other instances of localhost as well, and just published v5.7.4 with the changes. I'm also going to see if eslint_d (which this project forked from) needs an equivalent patch.

josephfrazier added a commit to josephfrazier/eslint_d.js that referenced this pull request Jan 8, 2018
If `localhost` doesn't resolve to `127.0.0.1`, the client cannot connect
to the server. This issue arose in josephfrazier/prettier_d#7,
and I ported the changes from there.
mantoni pushed a commit to mantoni/eslint_d.js that referenced this pull request Jan 8, 2018
If `localhost` doesn't resolve to `127.0.0.1`, the client cannot connect
to the server. This issue arose in josephfrazier/prettier_d#7,
and I ported the changes from there.
@nicolas-schmitt
Copy link
Author

Happy i could help and thanks for the quick release 😸

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants