Use toast notification instead of modal for warning/success messages #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I pinned to version 9.0.3 due to this issue: fkhadra/react-toastify#775
See https://reportedcab.slack.com/archives/C9VNM3DL4/p1672888880155269: > What do you think of replacing the react modals with alerts? instead > of dismissing the popup it would be some text that disappears after a > few seconds Unfortunately, the style of the notifications isn't currently correct, see below screenshot.
josephfrazier
temporarily deployed
to
reported-web-joseph-toa-3y9ovi
josephfrazier
temporarily deployed
to
reported-web-joseph-toa-3y9ovi
josephfrazier
temporarily deployed
to
reported-web-joseph-toa-3y9ovi
josephfrazier
changed the title
josephfrazier
temporarily deployed
to
reported-web-joseph-toa-3y9ovi
josephfrazier
temporarily deployed
to
reported-web-joseph-toa-3y9ovi
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://reportedcab.slack.com/archives/C9VNM3DL4/p1672888880155269:
I pinned to react-toastify version 9.0.3 due to this issue: fkhadra/react-toastify#775
See here for a demo of react-toastify: https://fkhadra.github.io/react-toastify/introduction
Example images:
mobile alert/warning:
desktop alert/warning:
desktop success: