Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/user registration #20

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Feat/user registration #20

merged 2 commits into from
Nov 29, 2023

Conversation

josephlee702
Copy link
Owner

____ Wrote Tests ____ Implemented ____ Reviewed

Neccesary checkmarks:

[x] All Tests are Passing

[] The code will run locally

Type of change

[x] New feature
[] Bug Fix

Implements/Fixes:

description closes #

Check the correct boxes

[x] This broke nothing
[] This broke some stuff
[] This broke everything

Testing Changes

[x] No Tests have been changed
[] Some Tests have been changed
[] All of the Tests have been changed(Please describe what in the world happened)

Checklist:

[x] My code has no unused/commented out code
[x] I have reviewed my code
[] I have commented my code, particularly in hard-to-understand areas
[x] I have fully tested my code

(For Fun!)Please Include a link to a gif of your feelings about this branch

Link:


click_on("Register")

x = User.find_by(name: "Thomas Smith")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this! I have received feedback not to use single character variables like x, but this is a really simple instance so I think we're ok.

@kameronk92 kameronk92 merged commit a2eb342 into main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants