Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch issue in 1.9. #31

Closed
KristofferC opened this issue Nov 4, 2022 · 4 comments
Closed

Dispatch issue in 1.9. #31

KristofferC opened this issue Nov 4, 2022 · 4 comments

Comments

@KristofferC
Copy link

KristofferC commented Nov 4, 2022

julia> ymat = randn(10, 5) ;

1.9:

julia> @which fit!(CovMatrix(), eachrow(ymat))
fit!(o::OnlineStat{T}, yi::T) where T
     @ OnlineStatsBase /OnlineStatsBase.jl/src/OnlineStatsBase.jl:111

1.8:

julia> @which fit!(CovMatrix(), eachrow(ymat))
fit!(o::OnlineStat{I}, y::T) where {I, T}
    in OnlineStatsBase at OnlineStatsBase.jl/src/OnlineStatsBase.jl:133

This causes the tests to fail.

I think the difference is that the result of eachrow is an AbstractVector on 1.9 but not on 1.8.

@KristofferC KristofferC changed the title Dspatch issue in 1.9. Dispatch issue in 1.9. Nov 4, 2022
@joshday
Copy link
Owner

joshday commented Nov 9, 2022

Thanks for the heads up. Fixed on master (untested).

@KristofferC
Copy link
Author

Looks like CI passed on nightly at least.

@KristofferC
Copy link
Author

Maybe make a new release? I debugged this again now :P

@joshday
Copy link
Owner

joshday commented Apr 14, 2023

Ooops...I'm on it!

@joshday joshday closed this as completed Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants