removed packages that weren't being used #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! Thanks a lot for your work! @dhuang612! 👍 |
jamescallumyoung
approved these changes
Oct 30, 2019
|
Hey @joshghent, this looks fine by me. I won't merge it until you approve it too though. Feel free to merge yourself if you approve 👍 @dhuang612 Thanks for the help here 👍 Good stuff. |
|
@jamescallumyoung thanks for reviewing that mate 👍 Great work @dhuang612 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So the build is failing according to github.
I opened an issue related to this and investigated
According to this:
microsoft/node-pty#319
It's something to do with node v 12 and windows builds.
They recommended installing node-pty@beta as a dev dependency which I did.
I'll review the travis logs to see if this resolves that.
The bundlesize command under package.json wasn't working.
updated bundlesize.config.json to accept module blobs
tested and confirmed it can now review the bundle sizes of the dist folder.
removed lodash package from package.json
and added the two individual modules that are being used in this project
.isEmpty & .map
removed giphy package as it wasn't being used
giphy-api is being used, left as is.
removed electron-debug package as it wasn't being used.
switched .travis.yml back to use npm run lint since yarn doesn't seem to be configured with this project.
tested this by cloning a fresh project down to computer when you run yarn start
Let me know if there is anything else that needs to be changed!