Api for sports list for a particular city #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| render json: {"error": I18n.t(city_sports.id_not_found)}, status: 422 if city_sports.nil? | ||
| city_sports.find_each do |citysport| | ||
| sport_list += Sport.where(id: citysport.sport_id) | ||
| end |
There was a problem hiding this comment.
@MayurDeshmukh10 Remove this loop
| city_sports.find_each do |citysport| | ||
| sport_list += Sport.where(id: citysport.sport_id) | ||
| end | ||
| render json: {"error": I18n.t(city_sports.sport_list_empty)}, status: 422 if sport_list.empty? |
There was a problem hiding this comment.
@MayurDeshmukh10 Sports List Empty does not necesaarily mean there is some error right?
| @@ -3,6 +3,8 @@ | |||
| Rails.application.routes.draw do | |||
| namespace :api do | |||
| namespace :v1 do | |||
| get "/city_sports/display", to: "city_sports#displaysports" | |||
| resources :city_sports | |||
There was a problem hiding this comment.
@MayurDeshmukh10 Why "resources :city_sports"?
| end | ||
|
|
||
| it "returns a unauthorized status due to jwt invalidation" do | ||
| @token3 = "eyJhbGciOiJIUzI1NiIsInR5cuKokeLSu9F62ck-CX2XvrquAsTNc9_agkPcYzk" |
There was a problem hiding this comment.
@MayurDeshmukh10 Dont pass the hard coded token. Generate it. You can write a method and call it everywhere in your test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.