Fixing batch sampling #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate the creation of the batch_sampler in a separate internal method. While doing that some small issues related to the nc= values were fixed.
Pull Request Test Coverage Report for Build 3596317313
💛 - Coveralls |
was confusing whether b refers to batch or base. Furthermore what was needed is just nlive_new
also get rid of blob in the IteratorShort as that is not used for anything other than printing
update the selection of the upper boundary for batch selection
|
Any comments @joshspeagle, otherwise I'll merge and aim to push a quick release, as the performance issue is pretty substantial. |
|
Unfortunately, I don't have time for a detailed review on this over the next day or two, so I'd say just merge this in to go for the performance improvement (well, some return to some past performance + all the additional changes). Thanks as always for continuing to clean up all the internals. The code is so much easier to work with now compared to when you first started taking a hammer to things. |
add myself to author field in setup.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR started as a fix to #415 , but because of the issue i thought we need to refactor that code,
so I've now completely separated the creation of the batch_sampler in a distinct method that makes things much easier to understand.
Also I've added more tests, some of which would have been tripped before the #415 fix